Migrate simple try-with-resources use of AgentScope to ContextScope#11763
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoJul 1, 2026
Merged
Conversation
mcculls
force-pushed
the
mcculls/context-scope-migration-1
branch
2 times, most recently
from
cfdacad to
7ababa2
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (334.115 µs) : 304, 364
. : milestone, 334,
basic (294.85 µs) : 288, 302
. : milestone, 295,
loop (8.972 ms) : 8966, 8977
. : milestone, 8972,
section candidate
noprobe (339.931 µs) : 298, 381
. : milestone, 340,
basic (292.935 µs) : 287, 299
. : milestone, 293,
loop (8.972 ms) : 8966, 8978
. : milestone, 8972,
|
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
mcculls
requested review from
PerfectSlayer,
claponcet,
jandro996,
mhlidd,
tylfin and
vandonr
and removed request for
a team
![datadog-datadog-prod-us1-2[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
More details
Uniform mechanical refactor across 88 files: every try-with-resources variable declaration changes from AgentScope to ContextScope, which is a valid widening reference conversion because AgentScope extends ContextScope. No method calls on the scope variable are added or removed; all callers (activateSpan, activateManualSpan, continuation.activate()) continue to return AgentScope at runtime, so close() dispatches identically via virtual method invocation. Null-scope safety in Wrapper.java is preserved by the JLS try-with-resources spec.
📊 Validated against 4 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 7ababa2 · What is Autotest? · Any feedback? Reach out in #autotest
daniel-mohedano
approved these changes
Jun 29, 2026
daniel-mohedano
left a comment
daniel-mohedano
left a comment
Contributor
There was a problem hiding this comment.
LGTM wrt CiVis changes
mcculls
force-pushed
the
mcculls/context-scope-migration-1
branch
from
7ababa2 to
e312c12
Compare
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: e312c12 | Docs | Datadog PR Page | Give us feedback! |
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
mcculls/context-scope-migration-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Reduce use of
AgentScopein the codebase - first round of migrationContributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]